From e7eb94be4506fad092ae5e30f0c40b3e4f308a06 Mon Sep 17 00:00:00 2001
From: Sandro <mail@sandrodach.de>
Date: Tue, 27 Oct 2026 17:35:47 +0100
Subject: [PATCH] fix(tasks): allow collaborative editor sharing in task lists

---
 frontend/src/components/UnifiedShareModal.tsx | 33 +++++++++++++++----
 frontend/src/features/triage/TasksView.tsx    |  1 +
 2 files changed, 28 insertions(+), 6 deletions(-)

diff --git a/frontend/src/components/UnifiedShareModal.tsx b/frontend/src/components/UnifiedShareModal.tsx
index 009f00e..cef88c8 100644
--- a/frontend/src/components/UnifiedShareModal.tsx
+++ b/frontend/src/components/UnifiedShareModal.tsx
@@ -24,6 +24,7 @@ export interface UnifiedShareModalProps {
   teams: Team[];
   collaborators: User[];
   allowRoleSelection?: boolean; // Default true (editor vs viewer)
+  fixedPermission?: 'editor' | 'viewer'; // When allowRoleSelection is false, force fixedPermission (default 'viewer' for documents, 'editor' for tasks/lists)
   onAddShare: (targetType: 'team' | 'user', targetId: string, permission: 'editor' | 'viewer') => Promise<void>;
   onRemoveShare: (shareId: string) => Promise<void>;
 }
@@ -40,14 +41,16 @@ export const UnifiedShareModal: React.FC<UnifiedShareModalProps> = ({
   teams,
   collaborators,
   allowRoleSelection = true,
+  fixedPermission,
   onAddShare,
   onRemoveShare,
 }) => {
+  const effectiveFixedPerm = fixedPermission || 'viewer';
   const [shareType, setShareType] = useState<'team' | 'user'>('team');
   const [selectedTeamId, setSelectedTeamId] = useState('');
   const [selectedUser, setSelectedUser] = useState<User | null>(null);
   const [selectedPermission, setSelectedPermission] = useState<'editor' | 'viewer'>(
-    allowRoleSelection ? 'editor' : 'viewer'
+    allowRoleSelection ? 'editor' : effectiveFixedPerm
   );
   const [loading, setLoading] = useState(false);
   const [error, setError] = useState<string | null>(null);
@@ -65,7 +68,7 @@ export const UnifiedShareModal: React.FC<UnifiedShareModalProps> = ({
 
     setLoading(true);
     try {
-      const permToUse = allowRoleSelection ? selectedPermission : 'viewer';
+      const permToUse = allowRoleSelection ? selectedPermission : effectiveFixedPerm;
       await onAddShare(shareType, targetId, permToUse);
       setSelectedTeamId('');
       setSelectedUser(null);
@@ -211,8 +214,17 @@ export const UnifiedShareModal: React.FC<UnifiedShareModalProps> = ({
                   </select>
                 ) : (
                   <span className="inline-flex items-center gap-1 text-[11px] text-muted px-2 py-1 bg-panel rounded border border-border shrink-0 self-center">
-                    <Lock className="w-3 h-3 text-faint" />
-                    Nur Lesen
+                    {effectiveFixedPerm === 'editor' ? (
+                      <>
+                        <Check className="w-3 h-3 text-accent" />
+                        Bearbeiten
+                      </>
+                    ) : (
+                      <>
+                        <Lock className="w-3 h-3 text-faint" />
+                        Nur Lesen
+                      </>
+                    )}
                   </span>
                 )}
               </div>
@@ -240,8 +252,17 @@ export const UnifiedShareModal: React.FC<UnifiedShareModalProps> = ({
                   </select>
                 ) : (
                   <span className="inline-flex items-center gap-1 text-[11px] text-muted px-2 py-1 bg-panel rounded border border-border shrink-0 self-center">
-                    <Lock className="w-3 h-3 text-faint" />
-                    Nur Lesen
+                    {effectiveFixedPerm === 'editor' ? (
+                      <>
+                        <Check className="w-3 h-3 text-accent" />
+                        Bearbeiten
+                      </>
+                    ) : (
+                      <>
+                        <Lock className="w-3 h-3 text-faint" />
+                        Nur Lesen
+                      </>
+                    )}
                   </span>
                 )}
               </div>
diff --git a/frontend/src/features/triage/TasksView.tsx b/frontend/src/features/triage/TasksView.tsx
index 3c057e4..99473f9 100644
--- a/frontend/src/features/triage/TasksView.tsx
+++ b/frontend/src/features/triage/TasksView.tsx
@@ -1978,6 +1978,7 @@ export const TasksView: React.FC<TasksViewProps> = ({
           teams={safeTeams}
           collaborators={safeCollaborators}
           allowRoleSelection={false}
+          fixedPermission="editor"
           onAddShare={async (targetType, targetId) => {
             await api.addTaskListShare(sharingTaskList.id, {
               targetType,